Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the need to annually update speaker-mod feature #855

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lazerwalker
Copy link
Collaborator

@lazerwalker lazerwalker commented Sep 8, 2024

This parameterizes the "make current speaker" and "make last year speaker" function calls and text so there's one less thing to update every year. It then also changes how speaker status works, so that we store actual speaker years in the DB, and only give the special 'speaker' badge to current-year speakers so we don't need to update them.

It also updates a few other other instances of relying on updating the current hardcoded year.

Might be nice to think about a UI to add speakers prior to the year-before-last, but very low priority.

Not tested yet, will ping when I've tested locally. No need to merge imminently, very low benefit from pushing this through quickly. Will want to manually test on the server, should just make sure the Azure Functions server time isn't messed up.

Also intentionally removes the year from the HTML title, it's fine to have that just be "Roguelike Celebration"

@lazerwalker lazerwalker force-pushed the make-speaker-year branch 2 times, most recently from d9e5c5f to ca6e7d9 Compare October 19, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant